Added invoke workflow operation name to agent span #3249
Conversation
zhirafovod
left a comment
zhirafovod
left a comment
There was a problem hiding this comment.
LGTM with some conditional notes left on the PR.
|
@wrisa Is there any active discussions or doc about conditional nodes and how they can be represented, especially with gen ai workflows. For example conditional edges in langgraph. |
@singankit Not exactly, but we briefly presented step for intermediate steps like langchain's chains or CrewAi's tasks. According to SIG discussions, it seemed expensive as all the info could be captured on agent span as well and also it seemed more framework specific. If we can have more use cases like you suggested we can start the discussion maybe again. |
| This span SHOULD be reported by the instrumentations when they can | ||
| reliably determine that invocation is a workflow (i.e. groups several agent | ||
| invocations) and SHOULD NOT be reported by instrumentations that | ||
| can't distinguish it `invoke_workflow` from `invoke_agent`. |
There was a problem hiding this comment.
How would you recommend instrumenting ADK?
8 participants
Fixes #
Changes
Workflow proposal https://github.com/open-telemetry/semantic-conventions/blob/b6bfc44631e28e87a0252011a8898e8098cb0ff9/docs/gen-ai/Session-and-Workflow-for-GenAI-Observability.md discussion led to suggestion of invoke workflow operation name in agent span.
Important
Pull requests acceptance are subject to the triage process as described in Issue and PR Triage Management.
PRs that do not follow the guidance above, may be automatically rejected and closed.
Merge requirement checklist
[chore]